Skip to content

[Apps] login #6295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2025
Merged

[Apps] login #6295

merged 1 commit into from
Feb 20, 2025

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Feb 19, 2025 •
edited by pr-codex bot
Loading

wip

PR-Codex overview

This PR focuses on refactoring and enhancing the thirdweb-login application by removing unused files, updating dependencies, and introducing new features like enhanced authentication and theming support.

Detailed summary

  • Deleted unused files in apps/login.
  • Added jose dependency for JWT handling.
  • Introduced cn utility function in utils.ts.
  • Updated ESLint configuration.
  • Created new LoginLayout component with Suspense.
  • Implemented Provider and ThemeProvider components.
  • Added environment detection in getVercelEnv.
  • Created thirdwebClient in thirdweb-client.ts.
  • Configured new JSON schema in components.json.
  • Implemented JWT export in route.ts.
  • Enhanced permissions management in LoginForm.
  • Updated LoginPage to handle OAuth2 authorization.
  • Improved UI components for buttons, cards, and inputs.
  • Added PermissionCard for managing app permissions.
  • Updated Tailwind CSS configuration for dark mode support.
  • Added new utility components like Tooltip, Select, and Switch.
  • Implemented session management in siwe-server.ts.

The following files were skipped due to too many changes: apps/login/src/app/api/token/route.ts, apps/login/src/components/ui/dropdown-menu.tsx, pnpm-lock.yaml

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Feb 19, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2025 10:07am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2025 10:07am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2025 10:07am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2025 10:07am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2025 10:07am

@changeset-bot
Copy link

changeset-bot bot commented Feb 19, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: e66a625

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Playground Changes involving the Playground codebase. label Feb 19, 2025
@jnsdls Graphite App
Copy link
Member Author

jnsdls commented Feb 19, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jnsdls jnsdls added the DO NOT MERGE This pull request is still in progress and is not ready to be merged. label Feb 19, 2025 — with Graphite App
@jnsdls jnsdls marked this pull request as ready for review February 19, 2025 08:35
@jnsdls jnsdls requested review from a team and joaquim-verges as code owners February 19, 2025 08:35
@jnsdls jnsdls force-pushed the 02-08-update_login branch 2 times, most recently from 5fc5673 to 30d9dc2 Compare February 19, 2025 08:38
@jnsdls jnsdls force-pushed the 02-08-update_login branch from 30d9dc2 to 96f5ea7 Compare February 19, 2025 08:40
@jnsdls jnsdls force-pushed the 02-08-update_login branch from 96f5ea7 to b56089e Compare February 19, 2025 08:49
@vercel vercel bot temporarily deployed to Preview – login February 19, 2025 08:50 Inactive
@jnsdls jnsdls force-pushed the 02-08-update_login branch from b56089e to 12d9d84 Compare February 19, 2025 08:51
graphite-app[bot]
graphite-app bot reviewed Feb 20, 2025
View reviewed changes
apps/login/src/app/api/token/route.ts
Comment on lines +137 to +143
console.log(
"expectedChallenge",
expectedChallenge,
"code_challenge",
code_challenge,
codeVerifier,
);
Copy link
Contributor

@graphite-app graphite-app bot Feb 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This debug logging exposes sensitive PKCE verification details that should not be present in production. Consider removing the console.log statement to prevent leaking code verifier and challenge values in logs.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

@joaquim-verges joaquim-verges changed the title update login [Apps] login Feb 20, 2025
@joaquim-verges joaquim-verges merged commit 439485b into main Feb 20, 2025
33 of 35 checks passed
@joaquim-verges joaquim-verges deleted the 02-08-update_login branch February 20, 2025 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@joaquim-verges joaquim-verges Awaiting requested review from joaquim-verges joaquim-verges is a code owner

Assignees

No one assigned

Labels

DO NOT MERGE This pull request is still in progress and is not ready to be merged. Playground Changes involving the Playground codebase.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jnsdls @joaquim-verges